Issue 22411005: Added ResourceCache test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22411005: Added ResourceCache test (Closed)

Created:
7 years, 4 months ago by robertphillips

Modified:
7 years, 4 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, snorp

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This attempts to replicate some bad cache behavior Mozilla reported. Committed: http://code.google.com/p/skia/source/detail?r=10649

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -0 lines)			Patch
	M	gyp/tests.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	tests/ResourceCacheTest.cpp	View		1 chunk	+91 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm James, I think this test reflects your "render a page to a canvas and ...

7 years, 4 months ago (2013-08-08 20:27:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/22411005/1

7 years, 4 months ago (2013-08-08 22:42:59 UTC) #3

jwillcox

7 years, 4 months ago (2013-08-21 13:36:31 UTC) #5

Message was sent while issue was closed.

On 2013/08/08 20:27:57, bsalomon wrote:
> lgtm
> 
> James, I think this test reflects your "render a page to a canvas and
readback"
> use case.

It does look pretty similar. Sadly, I cannot reproduce our issue with it. For
now I'm going to hope it's magically fixed in newer Skia revisions :)

Expand Messages | Collapse Messages