Move appcache_frontend_impl.* to content/renderer/

Move appcache_frontend_impl.* to content/child/

BUG=265753
TEST=content_unittests
R=jam@chromium.org,jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216942

[tfarina, 2013-08-08 23:07:18]

https://codereview.chromium.org/22410007/diff/1/content/worker/DEPS
File content/worker/DEPS (right):

https://codereview.chromium.org/22410007/diff/1/content/worker/DEPS#newcode3
content/worker/DEPS:3: "+content/renderer/appcache_frontend_impl.h",
John, is this OK?

[michaeln, 2013-08-08 23:51:15]

https://codereview.chromium.org/22410007/diff/1/content/worker/DEPS
File content/worker/DEPS (right):

https://codereview.chromium.org/22410007/diff/1/content/worker/DEPS#newcode3
content/worker/DEPS:3: "+content/renderer/appcache_frontend_impl.h",
This file/class should be in content/child instead of content/renderer. Same
thing for web_application_cache_host_impl.cc .h

[tfarina, 2013-08-08 23:53:57]

https://codereview.chromium.org/22410007/diff/1/content/worker/DEPS
File content/worker/DEPS (right):

https://codereview.chromium.org/22410007/diff/1/content/worker/DEPS#newcode3
content/worker/DEPS:3: "+content/renderer/appcache_frontend_impl.h",
On 2013/08/08 23:51:15, michaeln wrote:
> This file/class should be in content/child instead of content/renderer. Same
> thing for web_application_cache_host_impl.cc .h

I'm not moving web_application_cache_host_impl.* in this patch because
webkit/support/test_webkit_platform_support.cc includes it. I'm not sure what do
do about test_webkit_platform_support.cc yet, so I'm leaving
web_application_cache_host_impl.* out of this patch for now, unless I hear some
suggestion about it.

Thanks, I'll move appcache_frontend_impl.* into content/child.

[tfarina, 2013-08-09 00:08:46]

Michael, PTAL!

[michaeln, 2013-08-09 00:27:13]

lgtm

And if you can find a way to delete webkit_support and
test_webkit_platform_support.cc, that'd be great! What uses those and why, bleh
i don't want to know :)

> test_webkit_platform_support.cc includes it
does it really need to even, i don't see the compile time dependency?

[michaeln, 2013-08-09 00:39:53]

On 2013/08/09 00:27:13, michaeln wrote:
> lgtm
> 
> And if you can find a way to delete webkit_support and
> test_webkit_platform_support.cc, that'd be great! What uses those and why,
bleh
> i don't want to know :)
> 
> > test_webkit_platform_support.cc includes it
> does it really need to even, i don't see the compile time dependency?

The file compiles w/o the include. I think you could move it.

[tfarina, 2013-08-09 00:41:53]

On 2013/08/09 00:39:53, michaeln wrote:
> On 2013/08/09 00:27:13, michaeln wrote:
> > lgtm
> > 
> > And if you can find a way to delete webkit_support and
> > test_webkit_platform_support.cc, that'd be great! What uses those and why,
> bleh
> > i don't want to know :)
> > 
> > > test_webkit_platform_support.cc includes it
> > does it really need to even, i don't see the compile time dependency?
> 
> The file compiles w/o the include. I think you could move it.

OK. I'll move it and remove the include.

[tfarina, 2013-08-09 01:31:32]

Moved. Michael, ptal!

[jam, 2013-08-09 03:54:29]

lgtm with nits

https://codereview.chromium.org/22410007/diff/20001/content/child/appcache_fr...
File content/child/appcache_frontend_impl.h (right):

https://codereview.chromium.org/22410007/diff/20001/content/child/appcache_fr...
content/child/appcache_frontend_impl.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
please put all these moved appcache files to content/child/appcache directory.
then we can move the existing 4 appcache files in content/child to that
subdirectory as well. add michaeln as the owner

https://codereview.chromium.org/22410007/diff/20001/content/renderer/webplugi...
File content/renderer/webplugin_impl.cc (right):

https://codereview.chromium.org/22410007/diff/20001/content/renderer/webplugi...
content/renderer/webplugin_impl.cc:19: #include
"content/child/web_application_cache_host_impl.h"
nit: this isn't needed

[michaeln, 2013-08-09 21:30:26]

lgtm2

[tfarina, 2013-08-09 21:49:18]

https://codereview.chromium.org/22410007/diff/20001/content/child/appcache_fr...
File content/child/appcache_frontend_impl.h (right):

https://codereview.chromium.org/22410007/diff/20001/content/child/appcache_fr...
content/child/appcache_frontend_impl.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2013/08/09 03:54:29, jam wrote:
> please put all these moved appcache files to content/child/appcache directory.
> then we can move the existing 4 appcache files in content/child to that
> subdirectory as well. add michaeln as the owner

Moved it over there and added OWNERS file.

[commit-bot: I haz the power, 2013-08-10 22:05:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/22410007/36001

[commit-bot: I haz the power, 2013-08-11 03:16:30]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-08-11 03:17:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/22410007/36001

[commit-bot: I haz the power, 2013-08-12 05:50:55]

Change committed as 216942