Issue 22409002: Remove managed user registration timeout.

Issue 22409002: Remove managed user registration timeout. (Closed)

Created:
7 years, 4 months ago by Bernhard Bauer

Modified:
7 years, 4 months ago

Reviewers:
Adrian Kuegel

CC:
chromium-reviews, Pam (message me for reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove managed user registration timeout. While Sync is being initialized, managed user registration can take way more than 30 seconds, so an automatic timeout does not give any benefit to the user. BUG=254042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215910

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix #

Total comments: 2

Patch Set 4 : review #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -45 lines)			Patch
M	chrome/browser/managed_mode/managed_user_registration_utility.h	View	1 2 3	3 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/managed_mode/managed_user_registration_utility.cc	View	1 2 3	5 chunks	+0 lines, -23 lines	0 comments	Download
M	chrome/browser/ui/webui/options/browser_options_handler.cc	View	1	2 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Adrian Kuegel

LGTM https://codereview.chromium.org/22409002/diff/6001/chrome/browser/managed_mode/managed_user_registration_utility.h File chrome/browser/managed_mode/managed_user_registration_utility.h (right): https://codereview.chromium.org/22409002/diff/6001/chrome/browser/managed_mode/managed_user_registration_utility.h#newcode16 chrome/browser/managed_mode/managed_user_registration_utility.h:16: #include "base/timer/timer.h" Do we still need this include?

7 years, 4 months ago (2013-08-06 13:15:39 UTC) #2

Bernhard Bauer

https://codereview.chromium.org/22409002/diff/6001/chrome/browser/managed_mode/managed_user_registration_utility.h File chrome/browser/managed_mode/managed_user_registration_utility.h (right): https://codereview.chromium.org/22409002/diff/6001/chrome/browser/managed_mode/managed_user_registration_utility.h#newcode16 chrome/browser/managed_mode/managed_user_registration_utility.h:16: #include "base/timer/timer.h" On 2013/08/06 13:15:39, Adrian Kuegel wrote: > ...

7 years, 4 months ago (2013-08-06 14:25:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/22409002/1005

7 years, 4 months ago (2013-08-06 14:25:33 UTC) #4

Message was sent while issue was closed.

Change committed as 215910

Expand Messages | Collapse Messages