Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 22407017: Remove whitelist restriction for Shared Modules on dev channel. (Closed)

Created:
7 years, 4 months ago by elijahtaylor1
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove whitelist restriction for Shared Modules on dev channel. Add another extension to the whitelist for Shared Modules on stable and supporting Pepper interfaces BUG=234789 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217112

Patch Set 1 #

Patch Set 2 : fix unit test + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_crx_file_system_message_filter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +14 lines, -8 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/pending_updates_with_imports/Preferences View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
elijahtaylor1
asargent: Main review, per Extension API review darin, yzshen: OWNERS approval
7 years, 4 months ago (2013-08-10 01:11:58 UTC) #1
yzshen1
pepper OWNER LGTM
7 years, 4 months ago (2013-08-12 16:00:39 UTC) #2
asargent_no_longer_on_chrome
lgtm
7 years, 4 months ago (2013-08-12 17:36:47 UTC) #3
darin (slow to review)
LGTM
7 years, 4 months ago (2013-08-12 18:14:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/22407017/25001
7 years, 4 months ago (2013-08-12 19:31:22 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 23:13:46 UTC) #6
Message was sent while issue was closed.
Change committed as 217112

Powered by Google App Engine
This is Rietveld 408576698