Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 22405002: Move the managed user ID validity check out of the general code path (Closed)

Created:
7 years, 4 months ago by ibra
Modified:
7 years, 4 months ago
Reviewers:
Bernhard Bauer, Sergiu
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move the managed user ID validity check out of the general code path. BUG=268786 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/ui/webui/options/browser_options_handler.cc View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ibra
Hi Bernhard, Can you please take a look? Thanks!
7 years, 4 months ago (2013-08-06 11:09:36 UTC) #1
Bernhard Bauer
LGTM. The CL description reads a bit awkward though, and in general just stating "Fix ...
7 years, 4 months ago (2013-08-06 11:22:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/22405002/1
7 years, 4 months ago (2013-08-06 11:26:06 UTC) #3
Bernhard Bauer
On 2013/08/06 11:26:06, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 4 months ago (2013-08-06 11:37:53 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 4 months ago (2013-08-06 14:02:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/22405002/1
7 years, 4 months ago (2013-08-06 14:07:55 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 14:08:13 UTC) #7
Message was sent while issue was closed.
Change committed as 215889

Powered by Google App Engine
This is Rietveld 408576698