Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 22404006: Make DesktopDragDropClientAuraX11 not depend on DesktopRootWindowHostX11. (Closed)

Created:
7 years, 4 months ago by dshwang
Modified:
7 years, 4 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, dcheng, ben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make DesktopDragDropClientAuraX11 not depend on DesktopRootWindowHostX11. Currently DesktopDragDropClientAuraX11 does not use DesktopRootWindowHostX11 at all. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dshwang
7 years, 4 months ago (2013-08-09 13:08:24 UTC) #1
Elliot Glaysher
lgtm Huh. Thanks for the cleanup.
7 years, 4 months ago (2013-08-09 17:13:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/22404006/1
7 years, 4 months ago (2013-08-09 17:13:26 UTC) #3
dshwang
On 2013/08/09 17:13:16, Elliot Glaysher wrote: > lgtm > > Huh. Thanks for the cleanup. ...
7 years, 4 months ago (2013-08-09 21:04:29 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, content_browsertests, nacl_integration, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=157731
7 years, 4 months ago (2013-08-10 00:10:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/22404006/1
7 years, 4 months ago (2013-08-10 17:50:42 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 19:11:46 UTC) #7
Message was sent while issue was closed.
Change committed as 216885

Powered by Google App Engine
This is Rietveld 408576698