Issue 22403003: Update chrome://newtab checks in browser tests to use chrome::IsNTPURL().

Issue 22403003: Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). (Closed)

Created:
7 years, 4 months ago by kmadhusu

Modified:
7 years, 3 months ago

Reviewers:
samarth, sky

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, marja+watch_chromium.org, tfarina, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). BUG=229009 TEST=none TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220623

Patch Set 4 : Rebase + Addressed comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -31 lines)			Patch
M	chrome/browser/extensions/lazy_background_page_apitest.cc	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/policy_browsertest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc	View	1 2 3	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/sessions/session_restore_browsertest.cc	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_browsertest.cc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator_browsertest.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_browser_creator_browsertest.cc	View	1 2 3	10 chunks	+16 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views_browsertest.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

samarth

lgtm https://codereview.chromium.org/22403003/diff/25001/chrome/browser/extensions/extension_url_rewrite_browsertest.cc File chrome/browser/extensions/extension_url_rewrite_browsertest.cc (right): https://codereview.chromium.org/22403003/diff/25001/chrome/browser/extensions/extension_url_rewrite_browsertest.cc#newcode83 chrome/browser/extensions/extension_url_rewrite_browsertest.cc:83: EXPECT_TRUE(chrome::IsNTPURL(GetNavigationEntry()->GetURL(), profile())); I don't think we want to ...

7 years, 3 months ago (2013-08-30 15:33:56 UTC) #3

kmadhusu

samarth@: Addressed comments. Since this is a trivial change, I am TBR'ing sky@ to do ...

7 years, 3 months ago (2013-08-30 17:16:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/22403003/33001

7 years, 3 months ago (2013-08-30 17:17:05 UTC) #5

Message was sent while issue was closed.

Change committed as 220623

Expand Messages | Collapse Messages