chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java - Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java

Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java

index e2bfaff1bb636c9df8df0ca9790bb1f5f9d46ba5..7b5215720ef37b2ccb1c1549d72c8fb6a3c82b94 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java

@@ -53,8 +53,8 @@ class FilterAdapter extends BaseAdapter

R.layout.download_manager_ui_drawer_filter, null);

}

- int iconId = DownloadFilter.FILTER_LIST[position][0];

- labelView.setText(DownloadFilter.FILTER_LIST[position][1]);

+ int iconId = DownloadFilter.getDrawableForFilter(position);

+ labelView.setText(DownloadFilter.getStringIdForFilter(position));

Drawable iconDrawable = null;

if (position == mSelectedIndex) {

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java ('k') | no next file » | no next file with comments »