chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values-v17/styles.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index 22553bd67afaa904db916040230234e1cbbab4e8..ccdc94556c36819ba1c1b22bdefd8e76fd427fda 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -1531,6 +1531,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

} else if (id == R.id.bookmark_this_page_id) {

addOrEditBookmark(currentTab);

RecordUserAction.record("MobileMenuAddToBookmarks");

+ } else if (id == R.id.offline_page_id) {

+ // TODO(dfalcantara): Hook up offline page downloading.

} else if (id == R.id.reload_menu_id) {

if (currentTab.isLoading()) {

currentTab.stopLoading();