chrome/android/java/res/layout/icon_row_menu_item.xml - Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/icon_row_menu_item.xml

Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

8 android:layout_width="match_parent"	8 android:layout_width="match_parent"

9 android:layout_height="?android:attr/listPreferredItemHeightSmall"	9 android:layout_height="?android:attr/listPreferredItemHeightSmall"

10 android:layout_gravity="top\|start"	10 android:layout_gravity="top\|start"

11 android:orientation="horizontal">	11 android:orientation="horizontal">

12	12

13 <org.chromium.chrome.browser.widget.TintedImageButton	13 <org.chromium.chrome.browser.widget.TintedImageButton

14 android:id="@+id/button_one"	14 android:id="@+id/button_one"

15 android:layout_width="0dp"	15 style="@style/OverflowMenuButton" />

16 android:layout_height="match_parent"

17 android:layout_weight="1"

18 android:background="?attr/listChoiceBackgroundIndicator"

19 android:scaleType="center" />

20	16

21 <org.chromium.chrome.browser.widget.TintedImageButton	17 <org.chromium.chrome.browser.widget.TintedImageButton

22 android:id="@+id/button_two"	18 android:id="@+id/button_two"

23 android:layout_width="0dp"	19 style="@style/OverflowMenuButton" />

24 android:layout_height="match_parent"

25 android:layout_weight="1"

26 android:background="?attr/listChoiceBackgroundIndicator"

27 android:scaleType="center" />

28	20

29 <org.chromium.chrome.browser.widget.TintedImageButton	21 <org.chromium.chrome.browser.widget.TintedImageButton

30 android:id="@+id/button_three"	22 android:id="@+id/button_three"

31 android:layout_width="0dp"	23 style="@style/OverflowMenuButton" />

32 android:layout_height="match_parent"	24

33 android:layout_weight="1"	25 <org.chromium.chrome.browser.widget.TintedImageButton

34 android:background="?attr/listChoiceBackgroundIndicator"	26 android:id="@+id/button_four"

35 android:scaleType="center" />	27 style="@style/OverflowMenuButton" />

	28

	29 <org.chromium.chrome.browser.widget.TintedImageButton

	30 android:id="@+id/button_five"

	31 style="@style/OverflowMenuButton" />

36 </LinearLayout>	32 </LinearLayout>

OLD	NEW