Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22401002: Add GetTextInputMode function to TextInputClient. (Closed)

Created:
7 years, 4 months ago by yoichio
Modified:
7 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add GetTextInputMode function to TextInputClient. All implementation return TEXT_INPUT_MODE_DEFAULT for now. RenderWidgetHostViewWin/Aura will change implementation. This method will be used for Windows8 Metro inputscope. BUG=244688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216671

Patch Set 1 #

Patch Set 2 : Fix build failure on win #

Total comments: 2

Patch Set 3 : Reorder declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_ibus_unittest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ime/text_input_client.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ui/base/ime/win/tsf_text_store_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/prefix_selector.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/prefix_selector.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/ime/input_method_bridge.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/ime/input_method_bridge.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yoichio
7 years, 4 months ago (2013-08-06 10:16:00 UTC) #1
Seigo Nonaka
lgtm
7 years, 4 months ago (2013-08-06 16:07:27 UTC) #2
yoichio
+sky@ as OWNER
7 years, 4 months ago (2013-08-07 00:02:22 UTC) #3
Yohei Yukawa
https://codereview.chromium.org/22401002/diff/9001/ui/base/ime/text_input_client.h File ui/base/ime/text_input_client.h (right): https://codereview.chromium.org/22401002/diff/9001/ui/base/ime/text_input_client.h#newcode70 ui/base/ime/text_input_client.h:70: // Returns current text input mode. It could be ...
7 years, 4 months ago (2013-08-07 04:03:29 UTC) #4
yoichio
https://chromiumcodereview.appspot.com/22401002/diff/9001/ui/base/ime/text_input_client.h File ui/base/ime/text_input_client.h (right): https://chromiumcodereview.appspot.com/22401002/diff/9001/ui/base/ime/text_input_client.h#newcode70 ui/base/ime/text_input_client.h:70: // Returns current text input mode. It could be ...
7 years, 4 months ago (2013-08-07 06:13:14 UTC) #5
Yohei Yukawa
lgtm
7 years, 4 months ago (2013-08-07 06:19:42 UTC) #6
yoichio
sky@ looks OOO so add ben@ as OWNER. Could you review?
7 years, 4 months ago (2013-08-07 07:46:39 UTC) #7
yoichio
I found ben is also off.... Then, add following OWNERs: +jochen@ for content/browser/renderer_host/*. +nona@ for ...
7 years, 4 months ago (2013-08-08 02:08:13 UTC) #8
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-08 02:20:29 UTC) #9
sadrul
LGTM
7 years, 4 months ago (2013-08-08 08:08:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/22401002/22001
7 years, 4 months ago (2013-08-09 00:56:05 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 12:45:21 UTC) #12
Message was sent while issue was closed. 
Change committed as 216671

Powered by Google App Engine
This is Rietveld 408576698