Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 22398007: Do not show create shortcuts on context menus for the Mac app list (Closed)

Created:
7 years, 4 months ago by tapted
Modified:
7 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Do not show create shortcuts on context menus for the Mac app launcher BUG=270306 TEST=With app shortcuts enabled on Mac, right-click a v2 platform app in the OSX App Launcher. "Create Shortcuts" should not present. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tapted
I think the outcome was that we wanted this..
7 years, 4 months ago (2013-08-09 07:49:01 UTC) #1
benwells
lgtm
7 years, 4 months ago (2013-08-11 23:50:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/22398007/1
7 years, 4 months ago (2013-08-12 03:02:57 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 07:02:35 UTC) #4
Message was sent while issue was closed.
Change committed as 216951

Powered by Google App Engine
This is Rietveld 408576698