Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 22394008: [Win] Only show bell tray icon after a notification. (Closed)

Created:
7 years, 4 months ago by dewittj
Modified:
7 years, 4 months ago
Reviewers:
jianli
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

[Win] Only show bell tray icon after a notification. People who never see a notification should not have their desktop cluttered with extra status tray icons, so we'll hold off on creating it until we have a good reason to. R=jianli@chromium.org BUG=270688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/views/message_center/web_notification_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dewittj
7 years, 4 months ago (2013-08-09 16:10:48 UTC) #1
jianli
lgtm
7 years, 4 months ago (2013-08-09 17:05:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/22394008/1
7 years, 4 months ago (2013-08-09 17:32:13 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 08:22:04 UTC) #4
Message was sent while issue was closed.
Change committed as 216827

Powered by Google App Engine
This is Rietveld 408576698