Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 22390005: Change Extensions.ExternalItemState to report more specific data (enabled (Closed)

Created:
7 years, 4 months ago by Matt Perry
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Change Extensions.ExternalItemState to report more specific data (enabled and disabled state and whether the extension updates from the webstore). BUG=268666 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -16 lines) Patch
M chrome/browser/extensions/installed_loader.cc View 3 chunks +33 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Matt Perry
7 years, 4 months ago (2013-08-08 21:30:03 UTC) #1
Yoyo Zhou
LGTM
7 years, 4 months ago (2013-08-08 21:38:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/22390005/1
7 years, 4 months ago (2013-08-08 21:41:09 UTC) #3
Matt Perry
alexei: OWNERS review for histograms.xml
7 years, 4 months ago (2013-08-08 21:46:59 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=19663
7 years, 4 months ago (2013-08-08 22:51:46 UTC) #5
Alexei Svitkine (slow)
lgtm
7 years, 4 months ago (2013-08-09 18:38:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/22390005/1
7 years, 4 months ago (2013-08-12 19:31:13 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 22:12:03 UTC) #8
Message was sent while issue was closed.
Change committed as 217094

Powered by Google App Engine
This is Rietveld 408576698