Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 22388002: Fix DeferredInstanceMigration to store the result to temp rather than temp to result. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5201 matching lines...) Expand 10 before | Expand all | Expand 10 after
5212 } 5212 }
5213 DeoptimizeIf(ne, instr->environment()); 5213 DeoptimizeIf(ne, instr->environment());
5214 } 5214 }
5215 5215
5216 5216
5217 void LCodeGen::DoDeferredInstanceMigration(LCheckMaps* instr, Register object) { 5217 void LCodeGen::DoDeferredInstanceMigration(LCheckMaps* instr, Register object) {
5218 { 5218 {
5219 PushSafepointRegistersScope scope(this, Safepoint::kWithRegisters); 5219 PushSafepointRegistersScope scope(this, Safepoint::kWithRegisters);
5220 __ push(object); 5220 __ push(object);
5221 CallRuntimeFromDeferred(Runtime::kMigrateInstance, 1, instr); 5221 CallRuntimeFromDeferred(Runtime::kMigrateInstance, 1, instr);
5222 __ StoreToSafepointRegisterSlot(scratch0(), r0); 5222 __ StoreToSafepointRegisterSlot(r0, scratch0());
5223 } 5223 }
5224 __ tst(scratch0(), Operand(kSmiTagMask)); 5224 __ tst(scratch0(), Operand(kSmiTagMask));
5225 DeoptimizeIf(eq, instr->environment()); 5225 DeoptimizeIf(eq, instr->environment());
5226 } 5226 }
5227 5227
5228 5228
5229 void LCodeGen::DoCheckMaps(LCheckMaps* instr) { 5229 void LCodeGen::DoCheckMaps(LCheckMaps* instr) {
5230 class DeferredCheckMaps: public LDeferredCode { 5230 class DeferredCheckMaps: public LDeferredCode {
5231 public: 5231 public:
5232 DeferredCheckMaps(LCodeGen* codegen, LCheckMaps* instr, Register object) 5232 DeferredCheckMaps(LCodeGen* codegen, LCheckMaps* instr, Register object)
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
5839 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5839 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5840 __ ldr(result, FieldMemOperand(scratch, 5840 __ ldr(result, FieldMemOperand(scratch,
5841 FixedArray::kHeaderSize - kPointerSize)); 5841 FixedArray::kHeaderSize - kPointerSize));
5842 __ bind(&done); 5842 __ bind(&done);
5843 } 5843 }
5844 5844
5845 5845
5846 #undef __ 5846 #undef __
5847 5847
5848 } } // namespace v8::internal 5848 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698