Removing deprecated constructors and setDevice from SkDeferredCanvas

Removing deprecated constructors and setDevice from SkDeferredCanvas

R=senorblanco@google.com
BUR=crbug.com/270143

[Justin Novosad, 2013-08-08 19:48:43]

PTAL

N.B.: Must wait for Blink patch to land before committing this:
https://codereview.chromium.org/22634006/

[Stephen White, 2013-08-08 20:15:33]

LGTM

https://codereview.chromium.org/22385011/diff/1/include/utils/SkDeferredCanvas.h
File include/utils/SkDeferredCanvas.h (left):

https://codereview.chromium.org/22385011/diff/1/include/utils/SkDeferredCanva...
include/utils/SkDeferredCanvas.h:50: /** DEPRACATED, use create instead
So is it deprecated, or depracated?  I guess we'll never know.. ;)

[commit-bot: I haz the power, 2013-08-09 13:45:53]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/junov@chromium.org/22385011/1

[commit-bot: I haz the power, 2013-08-09 13:56:40]

Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s)
BuildTests
http://108.170.217.252:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Rele...

[commit-bot: I haz the power, 2013-08-09 14:08:58]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/junov@chromium.org/22385011/16003

[commit-bot: I haz the power, 2013-08-09 14:25:16]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/junov@chromium.org/22385011/16003

[commit-bot: I haz the power, 2013-08-09 14:25:22]

Failed to apply patch for bench/DeferredCanvasBench.cpp:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file bench/DeferredCanvasBench.cpp
  Hunk #1 FAILED at 29.
  1 out of 1 hunk FAILED -- saving rejects to file
bench/DeferredCanvasBench.cpp.rej

Patch:       bench/DeferredCanvasBench.cpp
Index: bench/DeferredCanvasBench.cpp
===================================================================
--- bench/DeferredCanvasBench.cpp	(revision 10642)
+++ bench/DeferredCanvasBench.cpp	(working copy)
@@ -29,12 +29,7 @@
         SkDevice *device = canvas->getDevice()->createCompatibleDevice(
             SkBitmap::kARGB_8888_Config, CANVAS_WIDTH, CANVAS_HEIGHT, false);
 
-        SkAutoTUnref<SkDeferredCanvas> deferredCanvas(
-#if SK_DEFERRED_CANVAS_USES_FACTORIES
-            SkDeferredCanvas::Create(device));
-#else
-            SkNEW_ARGS(SkDeferredCanvas, (device)));
-#endif
+        SkAutoTUnref<SkDeferredCanvas>
deferredCanvas(SkDeferredCanvas::Create(device));
         device->unref();
 
         initDeferredCanvas(deferredCanvas);

[rmistry, 2013-08-09 17:17:08]

+iannucci

Looks like this CL was successfully submitted by the CQ
(https://code.google.com/p/skia/source/detail?r=10657) but the last message was
a CQ patch failure. Any ideas Robbie?

Thanks!