Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: build/common.gypi

Issue 22384004: Change deployment target for iOS to 6.0 (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: update comment based on review feedback: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 0d20ba9a9385f8e9479b1ab3a9ba32347b2ca405..29f127804404af7cd425b54f8569bf3f7aba7c97 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1178,14 +1178,14 @@
# overridden from the command line the same way it is for a Mac build.
'mac_sdk%': '<!(python <(DEPTH)/build/mac/find_sdk.py 10.6)',
- # iOS SDK and deployment target support. The iOS 5.0 SDK is actually
- # what is required, but the value is left blank so when it is set in
- # the project files it will be the "current" iOS SDK. Forcing 5.0
- # even though it is "current" causes Xcode to spit out a warning for
- # every single project file for not using the "current" SDK.
+ # iOS SDK and deployment target support. The |ios_sdk| value is left
+ # blank so that when it is set in the project files it will be the
+ # "current" iOS SDK. Forcing a specific SDK even if it is "current"
+ # causes Xcode to spit out a warning for every single project file for
+ # not using the "current" SDK.
'ios_sdk%': '',
'ios_sdk_path%': '',
- 'ios_deployment_target%': '5.0',
+ 'ios_deployment_target%': '6.0',
'conditions': [
# ios_product_name is set to the name of the .app bundle as it should
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698