Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 22375009: Correcting bubble offsets of notifications when the tray menu is shown (Closed)

Created:
7 years, 4 months ago by Mr4D (OOO till 08-26)
Modified:
7 years, 4 months ago
CC:
chromium-reviews, tfarina, alicet1, sadrul, msw+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Correcting bubble offsets of notifications when the tray menu is shown BUG=263983 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ash/system/tray/tray_background_view.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mr4D (OOO till 08-26)
Harrym: Please do a review! msw&jamescook: Please do an owners review! Many thanks!
7 years, 4 months ago (2013-08-09 17:11:15 UTC) #1
Harry McCleave
lgtm
7 years, 4 months ago (2013-08-09 17:58:22 UTC) #2
msw
ui/views/bubble/tray_bubble_view.cc LGTM
7 years, 4 months ago (2013-08-09 18:22:45 UTC) #3
James Cook
lgtm
7 years, 4 months ago (2013-08-09 18:26:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/22375009/1
7 years, 4 months ago (2013-08-09 19:40:49 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-10 00:04:57 UTC) #6
Message was sent while issue was closed.
Change committed as 216785

Powered by Google App Engine
This is Rietveld 408576698