Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 22375004: Ensure sync footer visibility is always set correctly. (Closed)

Created:
7 years, 4 months ago by nyquist
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Ensure sync footer visibility is always set correctly. There is currently a race condition on updating the sync footer visibility on the welcome page. If the web page is created after the initial sync footer visibility state is sent, it is never sent again. This CL ensures that on startup, the state will always be correct. BUG=267352 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/ui/webui/welcome_handler_android.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/welcome_handler_android.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
nyquist
yfriedman: PTAL
7 years, 4 months ago (2013-08-09 01:20:02 UTC) #1
Yaron
lgtm
7 years, 4 months ago (2013-08-09 02:07:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/22375004/1
7 years, 4 months ago (2013-08-09 16:34:28 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=19803
7 years, 4 months ago (2013-08-09 16:49:50 UTC) #4
nyquist
jhawkins: PTAL for OWNERS
7 years, 4 months ago (2013-08-09 17:55:46 UTC) #5
Evan Stade
lgtm
7 years, 4 months ago (2013-08-09 21:13:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/22375004/1
7 years, 4 months ago (2013-08-09 21:16:07 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-09 21:57:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/22375004/1
7 years, 4 months ago (2013-08-10 00:06:15 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-10 00:15:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/22375004/1
7 years, 4 months ago (2013-08-10 00:22:06 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-10 00:40:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/22375004/1
7 years, 4 months ago (2013-08-12 15:18:46 UTC) #13
nyquist
all android-related bots passed. adding notry.
7 years, 4 months ago (2013-08-12 20:13:23 UTC) #14
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 4 months ago (2013-08-12 21:37:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/22375004/1
7 years, 4 months ago (2013-08-12 21:54:07 UTC) #16
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 22:01:51 UTC) #17
Message was sent while issue was closed.
Change committed as 217090

Powered by Google App Engine
This is Rietveld 408576698