Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 22373002: Extract copy operation related to Drive to fileOperationUtil. (Closed)

Created:
7 years, 4 months ago by hidehiko
Modified:
7 years, 4 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org, hirono
Visibility:
Public.

Description

Extract copy operation related to Drive to fileOperationUtil. This CL extracts copy operation related to Drive from processCopyEntry_ to an utility method copyFileOnDrive. BUG=246976 TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -74 lines) Patch
M chrome/browser/resources/file_manager/js/file_copy_manager.js View 2 chunks +148 lines, -74 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 4 months ago (2013-08-06 06:56:18 UTC) #1
mtomasz
lgtm, thanks!
7 years, 4 months ago (2013-08-06 08:39:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/22373002/1
7 years, 4 months ago (2013-08-06 08:42:16 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=156637
7 years, 4 months ago (2013-08-06 09:31:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/22373002/1
7 years, 4 months ago (2013-08-06 09:34:29 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=156649
7 years, 4 months ago (2013-08-06 10:20:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/22373002/1
7 years, 4 months ago (2013-08-06 10:24:02 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 11:13:11 UTC) #8
Message was sent while issue was closed.
Change committed as 215867

Powered by Google App Engine
This is Rietveld 408576698