[SyncFS] Add FileMetadata and FileTracker message

[SyncFS] Add FileMetadata and FileTracker for MetadataDatabase

BUG=240165
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215875

[tzik, 2013-08-06 07:34:28]

PTL

[nhiroki, 2013-08-06 07:50:59]

lgtm

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/metadata_database.proto
(right):

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:23: // Is
the sequence number of FileTrackers. Must be positive.
nit: s/"Is the"/"The"/

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:29:
repeated string parent_folder_ids = 1;
super-nit: How about adding extra blank line between l.29 and l.30. for
readability? (repeated vs. optional)

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:76: //
True indicates the folder contents has not yet been fetched.
nit: s/indicates/if/ (to make consistent with other lines like l.66)

[kinuko, 2013-08-06 07:51:00]

lgtm

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/metadata_database.proto
(right):

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:48:
optional FileDetails details = 2;
nit: can you put an empty line between 47-48

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:71: //
FileTracker.
nit: for -> to
nit: active FileTracker -> active trackers (or active FileTrackers)

'Remote file content modification' can be probably shortened to just 'Remote
modifications' or 'Remote changes'

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:76: //
True indicates the folder contents has not yet been fetched.
nit: has -> have

[tzik, 2013-08-06 08:33:45]

Thanks!

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/metadata_database.proto
(right):

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:23: // Is
the sequence number of FileTrackers. Must be positive.
On 2013/08/06 07:50:59, nhiroki wrote:
> nit: s/"Is the"/"The"/

Done.

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:29:
repeated string parent_folder_ids = 1;
On 2013/08/06 07:50:59, nhiroki wrote:
> super-nit: How about adding extra blank line between l.29 and l.30. for
> readability? (repeated vs. optional)

Done.

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:48:
optional FileDetails details = 2;
On 2013/08/06 07:51:00, kinuko wrote:
> nit: can you put an empty line between 47-48

Done.

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:71: //
FileTracker.
On 2013/08/06 07:51:00, kinuko wrote:
> nit: for -> to
> nit: active FileTracker -> active trackers (or active FileTrackers)
> 
> 'Remote file content modification' can be probably shortened to just 'Remote
> modifications' or 'Remote changes'

Done.

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:76: //
True indicates the folder contents has not yet been fetched.
On 2013/08/06 07:50:59, nhiroki wrote:
> nit: s/indicates/if/ (to make consistent with other lines like l.66)

Done.

https://codereview.chromium.org/22369003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.proto:76: //
True indicates the folder contents has not yet been fetched.
On 2013/08/06 07:51:00, kinuko wrote:
> nit: has -> have

Done.

[commit-bot: I haz the power, 2013-08-06 09:31:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/22369003/7001

[commit-bot: I haz the power, 2013-08-06 11:43:09]

Change committed as 215875