Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 22363002: 2nd try: Support synchronous mode in WebFileWriterImpl (Closed)

Created:
7 years, 4 months ago by kinuko
Modified:
7 years, 4 months ago
Reviewers:
tzik
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org
Visibility:
Public.

Description

2nd try: Support synchronous mode in WebFileWriterImpl BUG=257349 TEST=no behavioral change yet Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215871

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -12 lines) Patch
M content/child/fileapi/webfilesystem_impl.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.cc View 1 5 chunks +44 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
Hi, I think I fixed the test breakages-- can you take a look at the ...
7 years, 4 months ago (2013-08-06 07:43:26 UTC) #1
tzik
lgtm
7 years, 4 months ago (2013-08-06 08:15:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/22363002/3001
7 years, 4 months ago (2013-08-06 08:54:31 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 11:26:52 UTC) #4
Message was sent while issue was closed.
Change committed as 215871

Powered by Google App Engine
This is Rietveld 408576698