Issue 22354004: Adding check for OS support to AVX

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22354004: Adding check for OS support to AVX (Closed)

Created:
7 years, 4 months ago by DaleCurtis

Modified:
7 years, 4 months ago

Reviewers:
whunt, brettw, apatrick_chromium

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding check for OS support to AVX AVX support requires OS level support, this patch adds the relevant checks to ensure AVX is truly supported on a given cpu. It also fixes a missing initializer for has_avx_. This is a takeover of https://codereview.chromium.org/12511002/ from whunt@ who no longer works on the Chrome team. BUG=171824 TEST=none TBR=brettw,apatrick_chromium,whunt Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216795

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	base/cpu.cc	View		3 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

Carrying over previous lgtm's since this is just a rebase of https://codereview.chromium.org/12511002/

7 years, 4 months ago (2013-08-09 20:59:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/22354004/1

7 years, 4 months ago (2013-08-09 21:03:02 UTC) #2

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 4 months ago (2013-08-09 21:15:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/22354004/1

7 years, 4 months ago (2013-08-10 01:00:15 UTC) #4

Message was sent while issue was closed.

Change committed as 216795

Expand Messages | Collapse Messages