Issue 22354002: Remove SetModel in ContentsView and SearchBoxView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22354002: Remove SetModel in ContentsView and SearchBoxView. (Closed)

Created:
7 years, 4 months ago by calamity

Modified:
7 years, 4 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, xiyuan, tapted

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Remove SetModel in ContentsView and SearchBoxView. SetModel is only ever used for initialization. Moving the functionality into the constructor allows for easier reasoning about the state of the View. This change is in preparation of the refactor in https://codereview.chromium.org/20656002/. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215861

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -41 lines)			Patch
M	ui/app_list/views/app_list_main_view.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	ui/app_list/views/contents_view.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	ui/app_list/views/contents_view.cc	View		2 chunks	+6 lines, -11 lines	0 comments	Download
M	ui/app_list/views/search_box_view.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/app_list/views/search_box_view.cc	View	1	3 chunks	+10 lines, -19 lines	0 comments	Download

Total messages: 4 (0 generated)

koz (OOO until 15th September)

lgtm Thanks for splitting the change up!

7 years, 4 months ago (2013-08-06 03:15:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/22354002/7001

7 years, 4 months ago (2013-08-06 06:46:43 UTC) #3

Message was sent while issue was closed.

Change committed as 215861