Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 22353017: Fix the "throb" animation for the immersive fullscreen light bars (Closed)

Created:
7 years, 4 months ago by pkotwicz
Modified:
7 years, 4 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix the "throb" animation for the immersive fullscreen light bars - This CL darkens the light bars when they are throbbing. Previously, the light bars for inactive tabs would animate from 0 - 33% opacity. - This CL ignores the mini tab title animation for immersive fullscreen tabs. Previously, the inactive mini tabs would be completely transparent while the animation was running. BUG=265553 TEST=Manual, see bug R=jamescook TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216774

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/ui/views/tabs/tab.cc View 1 2 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pkotwicz
pkasting@, PTAL
7 years, 4 months ago (2013-08-08 00:33:02 UTC) #1
Peter Kasting
I'm not familiar with any of this code.
7 years, 4 months ago (2013-08-08 00:34:51 UTC) #2
pkotwicz
James, PTAL I assume that I will only end up landing this change when sky@ ...
7 years, 4 months ago (2013-08-08 00:42:33 UTC) #3
pkotwicz
For the sake of interest, getting the light bars to throb: - Open a whole ...
7 years, 4 months ago (2013-08-08 01:23:47 UTC) #4
James Cook
LGTM
7 years, 4 months ago (2013-08-08 16:17:42 UTC) #5
James Cook
On 2013/08/08 16:17:42, James Cook wrote: > LGTM Also, I think you could TBR this.
7 years, 4 months ago (2013-08-08 16:18:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/22353017/11001
7 years, 4 months ago (2013-08-09 15:51:15 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 23:19:58 UTC) #8
Message was sent while issue was closed.
Change committed as 216774

Powered by Google App Engine
This is Rietveld 408576698