ARM Skia NEON patches - 21 - new NEON S32_D565_Opaque

ARM Skia NEON patches - 21 - new NEON S32_D565_Opaque




BlitRow565: NEON version of S32_D565_Opaque

Here's a new implementation of S32_D565_Opaque in NEON. It
improves dramatically the speed compared to S32A_D565_Opaque.

Here are the benchmark results (speedup vs. existing NEON):

+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1     | +130%     | +139%      |
+-------+-----------+------------+
| 2     | +65,2%    | +51%       |
+-------+-----------+------------+
| 4     | -25,5%    | +10,2%     |
+-------+-----------+------------+
| 8     | +63,8%    | +32,1%     |
+-------+-----------+------------+
| 16    | +110%     | +49,2%     |
+-------+-----------+------------+
| 64    | +153%     | +123,5%    |
+-------+-----------+------------+
| 256   | +151%     | +144,7%    |
+-------+-----------+------------+
| 1024  | +272%     | +157,2%    |
+-------+-----------+------------+

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>;

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=11415

[kevin.petit.not.used.account, 2013-09-20 11:27:14]

ping.

This one should be pretty straightforward:
    - no mismatches
    - little code
    - huge speedup

It is also preventing me from sending its little brother.

[mtklein, 2013-09-20 13:36:08]

lgtm

https://codereview.chromium.org/22351006/diff/1/src/opts/SkBlitRow_opts_arm_n...
File src/opts/SkBlitRow_opts_arm_neon.cpp (right):

https://codereview.chromium.org/22351006/diff/1/src/opts/SkBlitRow_opts_arm_n...
src/opts/SkBlitRow_opts_arm_neon.cpp:52: dst += 1;
For symmetry I'd go with a ++ here.

[kevin.petit.not.used.account, 2013-09-20 14:41:56]

Patch Set 2 adds the suggested ++ and removes the dependency on
https://codereview.chromium.org/23719002/ by including the necessary NEON_*
defines.

https://codereview.chromium.org/22351006/diff/1/src/opts/SkBlitRow_opts_arm_n...
File src/opts/SkBlitRow_opts_arm_neon.cpp (right):

https://codereview.chromium.org/22351006/diff/1/src/opts/SkBlitRow_opts_arm_n...
src/opts/SkBlitRow_opts_arm_neon.cpp:52: dst += 1;
On 2013/09/20 13:36:08, mtklein wrote:
> For symmetry I'd go with a ++ here.

Done.

[mtklein, 2013-09-20 15:27:53]

lgtm

[commit-bot: I haz the power, 2013-09-20 15:28:05]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit.arm@gmail.com/22351006/5001

[commit-bot: I haz the power, 2013-09-20 15:38:55]

Change committed as 11415