Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 22349002: Linux Sandbox: print to stderr in CrashSIGSYS_Handler (Closed)

Created:
7 years, 4 months ago by jln (very slow on Chromium)
Modified:
7 years, 4 months ago
Reviewers:
Markus (顧孟勤)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jln+watch_chromium.org
Visibility:
Public.

Description

Linux Sandbox: print to stderr in CrashSIGSYS_Handler We always print to stderr if a system call is not handled by our sandbox. It is more friendly to developers than crashing in debug mode, and in release mode, this will allow to track issues when we can't have crash reports, which is for instance the case with NaCl. BUG=168812 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215819

Patch Set 1 #

Patch Set 2 : Small nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M content/common/sandbox_seccomp_bpf_linux.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jln (very slow on Chromium)
Markus, do you mind taking a look at this tiny CL ?
7 years, 4 months ago (2013-08-06 01:47:55 UTC) #1
Markus (顧孟勤)
lgtm
7 years, 4 months ago (2013-08-06 01:57:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/22349002/11001
7 years, 4 months ago (2013-08-06 02:40:44 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 06:19:15 UTC) #4
Message was sent while issue was closed.
Change committed as 215819

Powered by Google App Engine
This is Rietveld 408576698