Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3401)

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database.h

Issue 22341005: [SyncFS] Delete old MetadataDatabase code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync_file_system/drive_backend/metadata_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_backend/metadata_database.h
diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database.h b/chrome/browser/sync_file_system/drive_backend/metadata_database.h
index adfd468bd6e98eeb848d6699bb18b33d3db1c313..ea326d0613b4bc0d705085d9ffba4ca34292f4ee 100644
--- a/chrome/browser/sync_file_system/drive_backend/metadata_database.h
+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database.h
@@ -36,7 +36,6 @@ namespace sync_file_system {
namespace drive_backend {
class ServiceMetadata;
-class DriveFileMetadata;
struct DatabaseContents;
// MetadataDatabase instance holds and maintains database and its indexes. The
@@ -73,19 +72,7 @@ struct DatabaseContents;
// - have all children at the stored largest change id.
//
class MetadataDatabase {
- private:
- struct FileIDComparator {
- bool operator()(DriveFileMetadata* left, DriveFileMetadata* right) const;
- };
-
public:
- typedef std::set<DriveFileMetadata*, FileIDComparator> FileSet;
- typedef std::map<std::string, DriveFileMetadata*> FileByFileID;
- typedef std::map<std::string, FileSet> FilesByParent;
- typedef std::map<std::pair<std::string, std::string>, DriveFileMetadata*>
- FileByParentAndTitle;
- typedef std::map<std::string, DriveFileMetadata*> FileByAppID;
-
typedef base::Callback<
void(SyncStatusCode status, scoped_ptr<MetadataDatabase> instance)>
CreateCallback;
@@ -119,47 +106,6 @@ class MetadataDatabase {
void UnregisterApp(const std::string& app_id,
const SyncStatusCallback& callback);
- // Finds the app-root folder for |app_id|. Returns true if exists.
- // Copies the result to |folder| if it is non-NULL.
- bool FindAppRootFolder(const std::string& app_id,
- DriveFileMetadata* folder) const;
-
- // Finds file by |file_id|. Returns true if the file was found.
- // Copies the DriveFileMetadata instance identified by |file_id| into
- // |file| if exists and |file| is non-NULL.
- bool FindFileByFileID(const std::string& file_id,
- DriveFileMetadata* file) const;
-
- // Finds files by |title| under the folder identified by |folder_id|, and
- // returns the number of the files.
- // Copies the DriveFileMetadata instances to |files| if it is non-NULL.
- size_t FindFilesByParentAndTitle(
- const std::string& folder_id,
- const std::string& title,
- ScopedVector<DriveFileMetadata>* files) const;
-
- // Finds active file by |title| under the folder identified by |folder_id|.
- // Returns true if the file exists.
- bool FindActiveFileByParentAndTitle(
- const std::string& folder_id,
- const std::string& title,
- DriveFileMetadata* file) const;
-
- // Finds the active file identified by |app_id| and |path|, which must be
- // unique. Returns true if the file was found.
- // Copies the DriveFileMetadata instance into |file| if the file is found and
- // |file| is non-NULL.
- // |path| must be an absolute path in |app_id|. (i.e. relative to the app-root
- // folder.)
- bool FindActiveFileByPath(const std::string& app_id,
- const base::FilePath& path,
- DriveFileMetadata* file) const;
-
- // Looks up FilePath from FileID. Returns true on success.
- // |path| must be non-NULL.
- bool BuildPathForFile(const std::string& file_id,
- base::FilePath* path) const;
-
// Updates database by |changes|.
// Marks dirty for each changed file if the file has the metadata in the
// database. Adds new metadata to track the file if the file doesn't have
@@ -167,12 +113,6 @@ class MetadataDatabase {
void UpdateByChangeList(ScopedVector<google_apis::ChangeResource> changes,
const SyncStatusCallback& callback);
- // Populates |folder| with |children|. Each |children| initially has empty
- // |synced_details| and |remote_details|.
- void PopulateFolder(const std::string& folder_id,
- ScopedVector<google_apis::ResourceEntry> children,
- const SyncStatusCallback& callback);
-
private:
friend class MetadataDatabaseTest;
@@ -187,27 +127,6 @@ class MetadataDatabase {
SyncStatusCode InitializeOnTaskRunner(const base::FilePath& database_path);
void BuildIndexes(DatabaseContents* contents);
- // Database manipulation methods.
- void RegisterFolderAsAppRoot(const std::string& app_id,
- const std::string& folder,
- leveldb::WriteBatch* batch);
- void MakeFileActive(const std::string& file_id,
- leveldb::WriteBatch* batch);
- void MakeFileInactive(const std::string& file_id,
- leveldb::WriteBatch* batch);
- void UnregisterFolderAsAppRoot(const std::string& app_id,
- leveldb::WriteBatch* batch);
- void RemoveFile(const std::string& file_id,
- leveldb::WriteBatch* batch);
- void UpdateRemoteDetails(int64 change_id,
- const std::string& file_id,
- const google_apis::FileResource* file,
- leveldb::WriteBatch* batch);
- void RegisterNewFile(int64 change_id,
- const DriveFileMetadata& parent_folder,
- const google_apis::FileResource& new_file,
- leveldb::WriteBatch* batch);
-
void WriteToDatabase(scoped_ptr<leveldb::WriteBatch> batch,
const SyncStatusCallback& callback);
@@ -215,12 +134,6 @@ class MetadataDatabase {
scoped_ptr<leveldb::DB> db_;
scoped_ptr<ServiceMetadata> service_metadata_;
- FileByFileID file_by_file_id_; // Owned.
-
- FilesByParent files_by_parent_; // Not owned.
- FileByAppID app_root_by_app_id_; // Not owned.
- FileByParentAndTitle active_file_by_parent_and_title_; // Not owned.
- FileSet dirty_files_; // Not owned.
base::WeakPtrFactory<MetadataDatabase> weak_ptr_factory_;
« no previous file with comments | « no previous file | chrome/browser/sync_file_system/drive_backend/metadata_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698