src/effects/SkMatrixConvolutionImageFilter.cpp - Issue 22340010: Refactor GrGLUniformManager::UniformHandle to initialize itself by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMatrixConvolutionImageFilter.cpp

Issue 22340010: Refactor GrGLUniformManager::UniformHandle to initialize itself by default (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: description Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkMatrixConvolutionImageFilter.cpp

diff --git a/src/effects/SkMatrixConvolutionImageFilter.cpp b/src/effects/SkMatrixConvolutionImageFilter.cpp

index b3ce7ecc94e5faa58579439b50381ea8586d5422..c5420c66b69e0c16e5e318677f21cd26cbb7d973 100644

--- a/src/effects/SkMatrixConvolutionImageFilter.cpp

+++ b/src/effects/SkMatrixConvolutionImageFilter.cpp

@@ -351,11 +351,6 @@ private:

GrGLMatrixConvolutionEffect::GrGLMatrixConvolutionEffect(const GrBackendEffectFactory& factory,

const GrDrawEffect& drawEffect)

: INHERITED(factory)

- , fKernelUni(GrGLUniformManager::kInvalidUniformHandle)

- , fImageIncrementUni(GrGLUniformManager::kInvalidUniformHandle)

- , fTargetUni(GrGLUniformManager::kInvalidUniformHandle)

- , fGainUni(GrGLUniformManager::kInvalidUniformHandle)

- , fBiasUni(GrGLUniformManager::kInvalidUniformHandle)

, fEffectMatrix(drawEffect.castEffect<GrMatrixConvolutionEffect>().coordsType()) {

const GrMatrixConvolutionEffect& m = drawEffect.castEffect<GrMatrixConvolutionEffect>();

fKernelSize = m.kernelSize();

« no previous file with comments | « src/effects/SkMagnifierImageFilter.cpp ('k') | src/effects/SkMorphologyImageFilter.cpp » ('j') | no next file with comments »