Remove chrome.pak references, build resources into resources.pak

Remove chrome.pak references, build resources into resources.pak

This puts resources that used to be in chrome.pak and/or compiled in to
chrome.dll into resources.pak. resources.pak is already loaded at startup
on all platforms so having some resources in a separate pak file isn't
beneficial.

TBR=tony@chromium.org


BUG=52609
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216822

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217346

[jamesr, 2013-08-09 20:09:57]

I think this'll be a bit easier to wrangle than
https://codereview.chromium.org/22325015/ since it doesn't change the set of
deployed files on windows and only removes files on other platforms.

[tony, 2013-08-09 20:27:13]

It looks like android has some code to be removed.  Search for
kAndroidChromePakDescriptor.

LGTM once the bots and isolate tests go green.

https://codereview.chromium.org/22339020/diff/1/ash/ash.gyp
File ash/ash.gyp (left):

https://codereview.chromium.org/22339020/diff/1/ash/ash.gyp#oldcode908
ash/ash.gyp:908: '<(SHARED_INTERMEDIATE_DIR)/repack/chrome.pak',
I wonder if you should put resources.pak here, although I'm told ash on mac has
been side tabled so I don't think it really matters.

https://codereview.chromium.org/22339020/diff/1/chrome/browser_tests.isolate
File chrome/browser_tests.isolate (left):

https://codereview.chromium.org/22339020/diff/1/chrome/browser_tests.isolate#...
chrome/browser_tests.isolate:17: '<(PRODUCT_DIR)/chrome.pak',
I'm surprised that resources.pak isn't listed here or in the other .isolate
files, since tests probably already need resources.pak.  *shrug*

[jamesr, 2013-08-09 20:31:56]

On 2013/08/09 20:27:13, tony wrote:
> https://codereview.chromium.org/22339020/diff/1/chrome/browser_tests.isolate
> File chrome/browser_tests.isolate (left):
> 
>
https://codereview.chromium.org/22339020/diff/1/chrome/browser_tests.isolate#...
> chrome/browser_tests.isolate:17: '<(PRODUCT_DIR)/chrome.pak',
> I'm surprised that resources.pak isn't listed here or in the other .isolate
> files, since tests probably already need resources.pak.  *shrug*

resources.pak is listed in all of these isolate files.  The gyp here is a bit
confusing because chrome.pak is only added on os=win, but resources.pak is added
for both os==win and os==linux

[jamesr, 2013-08-09 21:19:39]

Looking pretty good on the trybots so far, I'll land once a few more cycle.

TBRing sky for the misc changes around the tree.

[commit-bot: I haz the power, 2013-08-09 21:39:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/22339020/11001

[commit-bot: I haz the power, 2013-08-09 22:46:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/22339020/10002

[commit-bot: I haz the power, 2013-08-10 07:31:03]

Change committed as 216822

[jamesr, 2013-08-12 21:36:59]

Reverted in r216823 because some gyp rules still cited 'chrome.pak' as a source
and I forgot to test with a clobber build.  I'll attempt relanding after the
branch point.

[jamesr, 2013-08-13 21:38:00]

Committed patchset #5 manually as r217346 (presubmit successful).