Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 22338004: Don't issue presubmit warning for use of wstrings in Windows-only files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tuple form of endswith Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 7f4af43c81b09e762eb9f9fc67d535f05a03e454..cefb599b18b102331a2fecd0b15cfd30335c2417 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -309,7 +309,7 @@ def _CheckNoNewWStrings(input_api, output_api):
problems = []
for f in input_api.AffectedFiles():
if (not f.LocalPath().endswith(('.cc', '.h')) or
- f.LocalPath().endswith('test.cc')):
+ f.LocalPath().endswith(('test.cc', '_win.cc', '_win.h'))):
continue
allowWString = False
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698