Don't issue presubmit warning for use of wstrings in Windows-only files.

Don't issue presubmit warning for use of wstrings in Windows-only files.

BUG=none
TEST=none
R=maruel@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220415

[Ilya Sherman, 2013-08-06 23:25:44]

Please CQ if lgty.  Thanks :)

[M-A Ruel, 2013-08-09 10:49:11]

use the tuple form of endswith(())
Le 6 août 2013 19:25, <isherman@chromium.org> a écrit :

> Reviewers: M-A Ruel OOO up to Aug 12th,
>
> Message:
> Please CQ if lgty.  Thanks :)
>
> Description:
> Don't issue presubmit warning for use of wstrings in Windows-only files.
>
> BUG=none
> TEST=none
> R=maruel@chromium.org
>
> Please review this at
https://chromiumcodereview.**appspot.com/22338004/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M PRESUBMIT.py
>
>
> Index: PRESUBMIT.py
> diff --git a/PRESUBMIT.py b/PRESUBMIT.py
> index 0b1f6c7f0b230212038e601a0d8792**d1faddb9b3..**
> 5473eeba60986ed8b7cce0c4cc16ac**35e454bdc7 100644
> --- a/PRESUBMIT.py
> +++ b/PRESUBMIT.py
> @@ -307,7 +307,9 @@ def _CheckNoNewWStrings(input_api, output_api):
>    problems = []
>    for f in input_api.AffectedFiles():
>      if (not f.LocalPath().endswith(('.cc', '.h')) or
> -        f.LocalPath().endswith('test.**cc')):
> +        f.LocalPath().endswith('test.**cc') or
> +        f.LocalPath().endswith('_win.**cc') or
> +        f.LocalPath().endswith('_win.**h')):
>        continue
>
>      allowWString = False
>
>
>

[Ilya Sherman, 2013-08-28 01:03:19]

On 2013/08/09 10:49:11, M-A Ruel wrote:
> use the tuple form of endswith(())

Done.  (Sorry for the delay -- was OOO these last couple of weeks.)

[M-A Ruel, 2013-08-29 14:46:59]

lgtm

[commit-bot: I haz the power, 2013-08-29 19:28:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/22338004/5001

[commit-bot: I haz the power, 2013-08-29 23:01:25]

Change committed as 220415