Made XmlWriter able to write elements with both attributes and content.

Made XmlWriter able to write elements with both attributes and content.

This adds a simple method to XmlWriter for appending content to an
already opened element. The only other way to add content to an element
was to call WriteElement, which doesn't allow adding attributes.

TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217309

[Avi (use Gerrit), 2013-08-07 14:58:25]

Looks plausible but I don't know the XmlWriter.

[Evan Martin, 2013-08-07 16:03:40]

LGTM


On Wed, Aug 7, 2013 at 12:31 AM, <julienp@opera.com> wrote:

> Reviewers: Avi, Evan Martin,
>
> Description:
> Made XmlWriter able to write elements with both attributes and content.
>
> This adds a simple method to XmlWriter for appending content to an
> already opened element. The only other way to add content to an element
> was to call WriteElement, which doesn't allow adding attributes.
>
> Please review this at
https://codereview.chromium.**org/22337003/<https://codereview.chromium.org/2...
>
> SVN Base:
https://chromium.googlesource.**com/chromium/src.git@master<https://chromium....
>
> Affected files:
>   M third_party/libxml/chromium/**libxml_utils.h
>
>
> Index: third_party/libxml/chromium/**libxml_utils.h
> diff --git a/third_party/libxml/chromium/**libxml_utils.h
> b/third_party/libxml/chromium/**libxml_utils.h
> index d230c5d9b23f3a5a561425a12beb49**501de87256..**
> 80d05f67d8df1a66fe3b5fe280af96**fb34fbabd7 100644
> --- a/third_party/libxml/chromium/**libxml_utils.h
> +++ b/third_party/libxml/chromium/**libxml_utils.h
> @@ -133,6 +133,12 @@ class XmlWriter {
>      return xmlTextWriterEndElement(**writer_) >= 0;
>    }
>
> +  // Appends to the content of the current open element.
> +  bool AppendElementContent(const std::string& content) {
> +    return xmlTextWriterWriteString(**writer_,
> +                                    BAD_CAST content.c_str()) >= 0;
> +  }
> +
>    // Adds an attribute to the current open element. Returns false on
> error.
>    bool AddAttribute(const std::string& attribute_name,
>                      const std::string& attribute_value) {
>
>
>

[commit-bot: I haz the power, 2013-08-07 16:07:42]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[julienp, 2013-08-08 09:03:21]

On 2013/08/07 16:07:42, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

I was suggested to add the owners of third_party as reviewer.
darin, brettw: Are you people able to lgtm this and make commit-bot more
cooperative? :)

[Avi (use Gerrit), 2013-08-08 15:11:55]

On 2013/08/08 09:03:21, julienp wrote:
> On 2013/08/07 16:07:42, I haz the power (commit-bot) wrote:
> > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > Even if an LGTM may have been provided, it was from a non-committer or
> > a lowly provisional committer, _not_ a full super star committer.
> > See http://www.chromium.org/getting-involved/become-a-committer
> > Note that this has nothing to do with OWNERS files.
> 
> I was suggested to add the owners of third_party as reviewer.
> darin, brettw: Are you people able to lgtm this and make commit-bot more
> cooperative? :)

No, read third_party/OWNERS again:

# Owner approval for 3rd party is only required for
# adding new libraries. For changes to existing code
# simply TBR= one of people below.

Just TBR one.

[julienp, 2013-08-12 12:41:46]

On 2013/08/08 15:11:55, Avi (OOO DO NOT ADD) wrote:
> On 2013/08/08 09:03:21, julienp wrote:
> > On 2013/08/07 16:07:42, I haz the power (commit-bot) wrote:
> > > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > > Even if an LGTM may have been provided, it was from a non-committer or
> > > a lowly provisional committer, _not_ a full super star committer.
> > > See http://www.chromium.org/getting-involved/become-a-committer
> > > Note that this has nothing to do with OWNERS files.
> > 
> > I was suggested to add the owners of third_party as reviewer.
> > darin, brettw: Are you people able to lgtm this and make commit-bot more
> > cooperative? :)
> 
> No, read third_party/OWNERS again:
> 
> # Owner approval for 3rd party is only required for
> # adding new libraries. For changes to existing code
> # simply TBR= one of people below.
> 
> Just TBR one.

Ok, I did so.
Can someone land this for me?

[Avi (use Gerrit), 2013-08-12 16:49:59]

On 2013/08/12 12:41:46, julienp wrote:
> On 2013/08/08 15:11:55, Avi (OOO DO NOT ADD) wrote:
> > On 2013/08/08 09:03:21, julienp wrote:
> > > On 2013/08/07 16:07:42, I haz the power (commit-bot) wrote:
> > > > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > > > Even if an LGTM may have been provided, it was from a non-committer or
> > > > a lowly provisional committer, _not_ a full super star committer.
> > > > See http://www.chromium.org/getting-involved/become-a-committer
> > > > Note that this has nothing to do with OWNERS files.
> > > 
> > > I was suggested to add the owners of third_party as reviewer.
> > > darin, brettw: Are you people able to lgtm this and make commit-bot more
> > > cooperative? :)
> > 
> > No, read third_party/OWNERS again:
> > 
> > # Owner approval for 3rd party is only required for
> > # adding new libraries. For changes to existing code
> > # simply TBR= one of people below.
> > 
> > Just TBR one.
> 
> Ok, I did so.
> Can someone land this for me?

Click the "Commit" checkbox.

[commit-bot: I haz the power, 2013-08-13 07:54:55]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[julienp, 2013-08-13 08:06:02]

On 2013/08/13 07:54:55, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

I tried checking commit again, this is what happens....

[Avi (use Gerrit), 2013-08-13 16:15:54]

On 2013/08/13 08:06:02, julienp wrote:
> On 2013/08/13 07:54:55, I haz the power (commit-bot) wrote:
> > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > Even if an LGTM may have been provided, it was from a non-committer or
> > a lowly provisional committer, _not_ a full super star committer.
> > See http://www.chromium.org/getting-involved/become-a-committer
> > Note that this has nothing to do with OWNERS files.
> 
> I tried checking commit again, this is what happens....

evmar should be a committer. LGTM and I'll try committing again.

[commit-bot: I haz the power, 2013-08-13 16:16:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/julienp@opera.com/22337003/1

[commit-bot: I haz the power, 2013-08-13 19:31:39]

Change committed as 217309