Issue 22336003: Manage fan-in for writable file entry checking on the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22336003: Manage fan-in for writable file entry checking on the UI thread. (Closed)

Created:
7 years, 4 months ago by Sam McNally

Modified:
7 years, 4 months ago

Reviewers:
benwells, kinaba

CC:
chromium-reviews, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, kinaba

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Manage fan-in for writable file entry checking on the UI thread. The Drive file operations are on the blocking pool (not the FILE thread) so the current fan-in is racy if multiple Drive files are selected. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215851

Patch Set 1 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -22 lines)			Patch
	M	chrome/browser/extensions/api/file_system/file_system_api.cc	View		2 chunks	+26 lines, -22 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/22336003/2002

7 years, 4 months ago (2013-08-06 01:22:56 UTC) #3

Message was sent while issue was closed.

Change committed as 215851

Expand Messages | Collapse Messages