components/web_contents_delegate_android/web_contents_delegate_android.h - Issue 2233213002: [Android] Suppress javascript dialogs from background tabs in custom tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.h

Issue 2233213002: [Android] Suppress javascript dialogs from background tabs in custom tab Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java ('k') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/web_contents_delegate_android.h

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.h b/components/web_contents_delegate_android/web_contents_delegate_android.h

index e349d17fb2eb1359bbf44f88857be8ce48f4fc8e..c1b9535094c93a647681fd8130c81ec544c74882 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.h

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.h

@@ -115,6 +115,7 @@ class WebContentsDelegateAndroid : public content::WebContentsDelegate {

const gfx::Rect& anchor_in_root_view) override;

void RequestAppBannerFromDevTools(

content::WebContents* web_contents) override;

+ bool ShouldSuppressDialogs(content::WebContents* web_contents) override;

protected:

base::android::ScopedJavaLocalRef<jobject> GetJavaDelegate(JNIEnv* env) const;