Issue 2233213002: [Android] Suppress javascript dialogs from background tabs in custom tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2233213002: [Android] Suppress javascript dialogs from background tabs in custom tab

Created:
4 years, 4 months ago by Ian Wen

Modified:
4 years, 4 months ago

Reviewers:
Yusuf, Avi (use Gerrit), no sievers

CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Suppress javascript dialogs from background tabs in custom tab Custom tabs look like they only hold one tab, while there might be multiple tabs in the tab model, if the newer tab is created via window.open(). If a background tab pops up a dialog, the current implementation will panic and the UI will break. This CL fixes this issue, by suppressing dialogs from hidden web contents. BUG=636520

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -0 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	components/web_contents_delegate_android/web_contents_delegate_android.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/web_contents_delegate_android/web_contents_delegate_android.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Avi (use Gerrit)

The java stuff I'm fuzzy on, but it looks reasonable and simple. LGTM!

4 years, 4 months ago (2016-08-10 23:45:25 UTC) #3

Ian Wen

4 years, 4 months ago (2016-08-10 23:56:56 UTC) #6

sievers@chromium.org: Please review changes in components

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages