Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 22332003: Add option to import from bookmarks html file to "Import Bookmarks..." dialog. (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Add option to import from bookmarks html file to "Import Bookmarks..." dialog. To test this new feature one can do the following: On chrome, open the "Import Bookmarks and Settings..." dialog, you can do this by three ways, one is to navigate to chrome://settings/importData, another is to open chrome://settings (either through wrench menu or navigating to it through omnibox) and then under the Users category click on "Import Bookmarks..." button to open the dialog. The third way to open this dialog is Wrench->Bookmarks->Import Bookmarks and Settings...". Once the dialog is opened, open the "From" combobox and select "Bookmarks HTML File" item. That should uncheck and disable all the checkboxes but "Favorites/Bookmarks" and present a "Choose file" button in the place where "Import" button was. Click on that new button and select your bookmarks html file, once you do that the import process should start, and if you file is ok, chrome should import and present you with a success message. BUG=80685 R=dbeam@chromium.org, isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216860

Patch Set 1 #

Patch Set 2 : rm debug code #

Total comments: 10

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/importer/importer_list.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.js View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.h View 5 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 1 2 5 chunks +56 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
I think there it is. Ilya -> chrome/browser/importer Dan -> chrome/browser/resources and chrome/browser/ui/webui/ Glen -> ...
7 years, 4 months ago (2013-08-06 03:50:29 UTC) #1
Dan Beam
lgtm assuming the file selector owns itself, might be useful to have some tests... https://chromiumcodereview.appspot.com/22332003/diff/3001/chrome/browser/resources/options/import_data_overlay.js ...
7 years, 4 months ago (2013-08-08 05:34:00 UTC) #2
Dan Beam
https://chromiumcodereview.appspot.com/22332003/diff/3001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/22332003/diff/3001/chrome/app/generated_resources.grd#newcode8285 chrome/app/generated_resources.grd:8285: + <message name="IDS_IMPORT_FROM_BOOKMARKS_HTML_FILE" desc="browser combo box: Bookmarks HTML File"> ...
7 years, 4 months ago (2013-08-08 05:37:05 UTC) #3
Ilya Sherman
importer lgtm, thanks. https://chromiumcodereview.appspot.com/22332003/diff/3001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/22332003/diff/3001/chrome/app/generated_resources.grd#newcode8285 chrome/app/generated_resources.grd:8285: + <message name="IDS_IMPORT_FROM_BOOKMARKS_HTML_FILE" desc="browser combo box: ...
7 years, 4 months ago (2013-08-08 08:09:28 UTC) #4
Dan Beam
https://chromiumcodereview.appspot.com/22332003/diff/3001/chrome/browser/ui/webui/options/import_data_handler.cc File chrome/browser/ui/webui/options/import_data_handler.cc (right): https://chromiumcodereview.appspot.com/22332003/diff/3001/chrome/browser/ui/webui/options/import_data_handler.cc#newcode219 chrome/browser/ui/webui/options/import_data_handler.cc:219: DCHECK(args && args->empty()); On 2013/08/08 08:09:28, Ilya Sherman (Away ...
7 years, 4 months ago (2013-08-08 21:33:11 UTC) #5
tfarina
https://chromiumcodereview.appspot.com/22332003/diff/3001/chrome/browser/importer/importer_list.cc File chrome/browser/importer/importer_list.cc (right): https://chromiumcodereview.appspot.com/22332003/diff/3001/chrome/browser/importer/importer_list.cc#newcode183 chrome/browser/importer/importer_list.cc:183: bookmarks_file->app_path.clear(); On 2013/08/08 08:09:28, Ilya Sherman (Away Aug. 9-25) ...
7 years, 4 months ago (2013-08-10 15:05:38 UTC) #6
tfarina
7 years, 4 months ago (2013-08-10 15:05:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r216860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698