Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 22329003: Unpremultiply SkBitmaps for PDF output (Closed)

Created:
7 years, 4 months ago by ducky
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Unpremultiply SkBitmaps for PDF output BUG=skia:236, chromium:175548 Committed: http://code.google.com/p/skia/source/detail?r=10725

Patch Set 1 #

Patch Set 2 : Add GM #

Total comments: 17

Patch Set 3 : Rename GM #

Total comments: 2

Patch Set 4 : Optimizations and cleanup #

Patch Set 5 : More cleanup #

Total comments: 6

Patch Set 6 : More style fixes #

Patch Set 7 : 80 cols #

Total comments: 9

Patch Set 8 : Style fixes; add stripe slide to GM #

Total comments: 6

Patch Set 9 : Style fix #

Patch Set 10 : More style fixes #

Patch Set 11 : Fix Windows build #

Total comments: 2

Patch Set 12 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -20 lines) Patch
A gm/bitmappremul.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +131 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +68 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
ducky
7 years, 4 months ago (2013-08-06 01:33:10 UTC) #1
vandebo (ex-Chrome)
https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (left): https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp#oldcode62 src/pdf/SkPDFImage.cpp:62: hasAlpha = true; Your unpremultiply call could drop in ...
7 years, 4 months ago (2013-08-07 18:02:47 UTC) #2
vandebo (ex-Chrome)
https://codereview.chromium.org/22329003/diff/3001/gm/bitmappremul.cpp File gm/bitmappremul.cpp (right): https://codereview.chromium.org/22329003/diff/3001/gm/bitmappremul.cpp#newcode71 gm/bitmappremul.cpp:71: return SkString("bitmap-premul"); short names tend to use _ and ...
7 years, 4 months ago (2013-08-07 18:11:07 UTC) #3
ducky
Fixed GM naming, not sure if restructuring unpremultiply according to your suggestion will work. https://codereview.chromium.org/22329003/diff/3001/gm/bitmappremul.cpp ...
7 years, 4 months ago (2013-08-08 03:35:10 UTC) #4
edisonn
Adding Mike I think we have plans to deprecate 4444, as I have seen in ...
7 years, 4 months ago (2013-08-08 12:20:57 UTC) #5
vandebo (ex-Chrome)
https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp#newcode25 src/pdf/SkPDFImage.cpp:25: static uint32_t unpremultiply_argb8888(uint32_t src) { On 2013/08/08 03:35:11, ducky ...
7 years, 4 months ago (2013-08-09 16:56:49 UTC) #6
ducky
Optimizations and cleanup https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp#newcode26 src/pdf/SkPDFImage.cpp:26: uint8_t a = SkGetPackedA32(src); On 2013/08/09 ...
7 years, 4 months ago (2013-08-09 21:45:14 UTC) #7
vandebo (ex-Chrome)
https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp#newcode26 src/pdf/SkPDFImage.cpp:26: uint8_t a = SkGetPackedA32(src); On 2013/08/09 21:45:14, ducky wrote: ...
7 years, 4 months ago (2013-08-12 15:56:05 UTC) #8
ducky
More style fixes! https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/22329003/diff/3001/src/pdf/SkPDFImage.cpp#newcode26 src/pdf/SkPDFImage.cpp:26: uint8_t a = SkGetPackedA32(src); On 2013/08/12 ...
7 years, 4 months ago (2013-08-12 20:51:58 UTC) #9
vandebo (ex-Chrome)
nits https://codereview.chromium.org/22329003/diff/35001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/22329003/diff/35001/src/pdf/SkPDFImage.cpp#newcode35 src/pdf/SkPDFImage.cpp:35: static void unpremultiply_and_pack_argb4444(uint8_t alpha0, uint8_t alpha1, Don't pass ...
7 years, 4 months ago (2013-08-12 22:20:48 UTC) #10
ducky
More style fixes. Also add striped test case to GM. https://codereview.chromium.org/22329003/diff/35001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/22329003/diff/35001/src/pdf/SkPDFImage.cpp#newcode35 ...
7 years, 4 months ago (2013-08-12 23:25:23 UTC) #11
vandebo (ex-Chrome)
LGTM after nits https://codereview.chromium.org/22329003/diff/47001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/22329003/diff/47001/src/pdf/SkPDFImage.cpp#newcode44 src/pdf/SkPDFImage.cpp:44: uint8_t alpha1 = SkGetPackedA4444(src1); nit move ...
7 years, 4 months ago (2013-08-13 16:04:47 UTC) #12
ducky
Fix nits and changes to GM to not break the Windows build. https://codereview.chromium.org/22329003/diff/47001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp ...
7 years, 4 months ago (2013-08-13 20:48:04 UTC) #13
vandebo (ex-Chrome)
LGTM with nits https://codereview.chromium.org/22329003/diff/62001/gm/bitmappremul.cpp File gm/bitmappremul.cpp (right): https://codereview.chromium.org/22329003/diff/62001/gm/bitmappremul.cpp#newcode17 gm/bitmappremul.cpp:17: * sets of greyscale gradients. Does ...
7 years, 4 months ago (2013-08-13 20:52:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/richardlin@chromium.org/22329003/71001
7 years, 4 months ago (2013-08-14 21:42:51 UTC) #15
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 22:02:27 UTC) #16
Message was sent while issue was closed.
Change committed as 10725

Powered by Google App Engine
This is Rietveld 408576698