Issue 22329002: fix allocator shim for multiple_dll debug build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22329002: fix allocator shim for multiple_dll debug build (Closed)

Created:
7 years, 4 months ago by scottmg

Modified:
7 years, 4 months ago

Reviewers:
jamesr

CC:
chromium-reviews, erikwright+watch_chromium.org, dmikurube+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

fix allocator shim for multiple_dll debug build allocator.gyp removes libcmt/libcmtd from link via direct_dependent_settings so having chrome_main_dll depend on it fixes the link. (I think it probably doesn't work in non-multiple_dll Debug either, but linking Debug-static_library with symbols doesn't work anyway so likely no one noticed.) R=jamesr@chromium.org BUG=262396 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215818