[TTS] Delay instrumentation tests at startup for flakes.

chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextualsearch;
 
 import static org.chromium.base.test.util.Restriction.RESTRICTION_TYPE_NON_LOW_END_DEVICE;
 import static org.chromium.content.browser.test.util.CriteriaHelper.DEFAULT_POLLING_INTERVAL;
 
 import android.app.Activity;
@@ skipping 58 matching lines @@
 // TODO(pedrosimonetti): Create class with limited API to encapsulate the internals of simulations.
 // TODO(pedrosimonetti): Separate tests into different classes grouped by type of tests. Examples:
 // Gestures (Tap, LongPress), Search Term Resolution (resolves, expand selection, prevent preload,
 // translation), Panel interaction (tap, fling up/down, close), Content (creation, loading,
 // visibility, history, delayed load), Tab Promotion, Policy (add tests to check if policies
 // affect the behavior correctly), General (remaining tests), etc.
 
 /**
  * Tests the Contextual Search Manager using instrumentation tests.
  */
-@CommandLineFlags.Add(ContextualSearchFieldTrial.SUPPRESSION_TAPS + "=1000")
+
 public class ContextualSearchManagerTest extends ChromeActivityTestCaseBase<ChromeActivity> {
 
     private static final String TEST_PAGE =
             "/chrome/test/data/android/contextualsearch/tap_test.html";
     private static final int TEST_TIMEOUT = 15000;
     private static final int TEST_EXPECTED_FAILURE_TIMEOUT = 1000;
     private static final int PLENTY_OF_TAPS = 1000;
 
     // TODO(donnd): get these from TemplateURL once the low-priority or Contextual Search API
     // is fully supported.
     private static final String NORMAL_PRIORITY_SEARCH_ENDPOINT = "/search?";
     private static final String LOW_PRIORITY_SEARCH_ENDPOINT = "/s?";
     private static final String CONTEXTUAL_SEARCH_PREFETCH_PARAM = "&pf=c";
+    // The number of ms to delay startup when a URL is being loaded.
+    private static final int ACTIVITY_STARTUP_DELAY_MS = 1000;

[Theresa, 2016/08/11 20:35:44]

Can we add a TODO note to fix this more correctly? Adding a 1 second startup
delay seems like a band aid and I suspect we'll still see flakes, just not as
frequently.

 
     private ActivityMonitor mActivityMonitor;
     private ContextualSearchFakeServer mFakeServer;
     private ContextualSearchManager mManager;
     private ContextualSearchPanel mPanel;
     private ContextualSearchPolicy mPolicy;
     private ContextualSearchSelectionController mSelectionController;
     private EmbeddedTestServer mTestServer;
 
     // State for an individual test.
@@ skipping 111 matching lines @@
     /**
      * Runs the given Runnable in the main thread.
      * @param runnable The Runnable.
      */
     public void runOnMainSync(Runnable runnable) {
         getInstrumentation().runOnMainSync(runnable);
     }
 
     @Override
     public void startMainActivity() throws InterruptedException {
-        startMainActivityWithURL(mTestServer.getURL(TEST_PAGE));
+        startMainActivityWithDelay(mTestServer.getURL(TEST_PAGE), ACTIVITY_STARTUP_DELAY_MS);

[Theresa, 2016/08/11 20:35:44]

I have a preference for putting the delay here instead of adding a method to
TestCaseBase. I'd like to prevent other tests from building in a sleep (better
to wait for specific initialization events).

     }
 
     //============================================================================================
     // Fake Searches Helpers
     //============================================================================================
 
     /**
      * Simulates a long-press triggered search.
      *
      * @param nodeId The id of the node to be long-pressed.
@@ skipping 2355 matching lines @@
         // Simulate a tap and assert that the panel peeks.
         simulateTapSearch("search");
 
         // Toggle tab to non-fullscreen.
         FullscreenTestUtils.togglePersistentFullscreenAndAssert(tab, false, getActivity());
 
         // Assert that the panel is closed.
         waitForPanelToClose();
     }
 }