Issue 22320003: Cleanup Views bubble tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22320003: Cleanup Views bubble tests. (Closed)

Created:
7 years, 4 months ago by msw

Modified:
7 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, alicet1, msw+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup bubble tests. Move NonClientHitTest to BubbleDelegateTest. Inline TestBubbleDelegateView function definitions. Add CreateTestWidget helper for anchors/parents/etc. Remove unnecessary Show and RunPendingMessages calls. Enable InitiallyFocusedView, it works fine as-is. (TestBubbleVisibilityAndClose already tests the same) Other misc. cleanup. BUG=NONE TEST=NONE TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215860

Patch Set 1 : Cleanup Views bubble tests. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -147 lines)			Patch
M	ui/views/bubble/bubble_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/bubble/bubble_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/bubble/bubble_delegate_unittest.cc	View	4 chunks	+81 lines, -97 lines	0 comments	Download
M	ui/views/bubble/bubble_frame_view_unittest.cc	View	4 chunks	+1 line, -48 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

msw

Hey Scott, please take a look as you have time, thanks. I'm using TBR since ...

7 years, 4 months ago (2013-08-06 06:33:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/22320003/13001

7 years, 4 months ago (2013-08-06 06:34:18 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages