Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 22311013: Removing QUIC's VERSION_6, now that QUIC no longer needs to support the (Closed)

Created:
7 years, 4 months ago by wtc
Modified:
7 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Removing QUIC's VERSION_6, now that QUIC no longer needs to support the older STREAM frames. Merge internal CL: 50558774 Add the QuicVersionMin() function. Change some unit tests to use QuicVersionMin(). Merge internal CL: 50630692 R=rch@chromium.org BUG=none TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217137

Patch Set 1 #

Patch Set 2 : Fix a typo in comment #

Patch Set 3 : Sync with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -641 lines) Patch
M net/quic/crypto/proof_source.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 2 1 chunk +17 lines, -15 lines 0 comments Download
M net/quic/quic_framer.h View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M net/quic/quic_framer.cc View 1 2 6 chunks +41 lines, -149 lines 0 comments Download
M net/quic/quic_framer_test.cc View 1 2 29 chunks +17 lines, -454 lines 0 comments Download
M net/quic/quic_protocol.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 2 3 chunks +5 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
7 years, 4 months ago (2013-08-09 18:53:36 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 4 months ago (2013-08-12 19:54:32 UTC) #2
Ryan Hamilton
lgtm
7 years, 4 months ago (2013-08-12 20:03:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/22311013/31001
7 years, 4 months ago (2013-08-12 20:06:45 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 00:44:15 UTC) #5
Message was sent while issue was closed.
Change committed as 217137

Powered by Google App Engine
This is Rietveld 408576698