Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 22311010: Remove some dead compositor-related webkit/support code (Closed)

Created:
7 years, 4 months ago by jamesr
Modified:
7 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews, apatrick_chromium, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Remove some dead compositor-related webkit/support code The code in webkit/support/ is only used by webkit_unit_tests, which never needs to support accelerated 2d canvas or threaded compositing. This removes some dead code related to those features formerly used by DumpRenderTree. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217024

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -61 lines) Patch
webkit/common/gpu/test_context_provider_factory.h View 1 chunk +0 lines, -3 lines 1 comment Download
webkit/common/gpu/test_context_provider_factory.cc View 1 chunk +0 lines, -7 lines 0 comments Download
webkit/support/test_webkit_platform_support.h View 4 chunks +0 lines, -16 lines 0 comments Download
webkit/support/test_webkit_platform_support.cc View 3 chunks +0 lines, -33 lines 0 comments Download
webkit/support/web_layer_tree_view_impl_for_testing.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
Hey Dana, want to review some removals? I'm still pondering what exactly to do about ...
7 years, 4 months ago (2013-08-09 02:04:25 UTC) #1
danakj
Do I! Mind uploading again? I'm getting error chunk mismatch.
7 years, 4 months ago (2013-08-09 14:27:54 UTC) #2
danakj
Oh, the inline diffs work. LGTM. https://codereview.chromium.org/22311010/diff/1/webkit/common/gpu/test_context_provider_factory.h File webkit/common/gpu/test_context_provider_factory.h (left): https://codereview.chromium.org/22311010/diff/1/webkit/common/gpu/test_context_provider_factory.h#oldcode24 webkit/common/gpu/test_context_provider_factory.h:24: Do you even ...
7 years, 4 months ago (2013-08-09 14:30:47 UTC) #3
jamesr
On 2013/08/09 14:30:47, danakj wrote: > https://codereview.chromium.org/22311010/diff/1/webkit/common/gpu/test_context_provider_factory.h > File webkit/common/gpu/test_context_provider_factory.h (left): > > https://codereview.chromium.org/22311010/diff/1/webkit/common/gpu/test_context_provider_factory.h#oldcode24 > ...
7 years, 4 months ago (2013-08-09 23:11:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/22311010/1
7 years, 4 months ago (2013-08-09 23:14:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=186151
7 years, 4 months ago (2013-08-10 07:00:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/22311010/1
7 years, 4 months ago (2013-08-12 16:33:53 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 17:10:33 UTC) #8
Message was sent while issue was closed.
Change committed as 217024

Powered by Google App Engine
This is Rietveld 408576698