Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2230913003: Experimental alignment layout manager using a property on the views

Created:
4 years, 4 months ago by kylix_rd
Modified:
4 years, 2 months ago
Reviewers:
robliao
CC:
chromium-reviews, tfarina, sky, Peter Kasting
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Herein lies an experimental layout manager which aligns the child views based on the value of the 'align' property of the view. The view can be aligned to the top, bottom, left, right or content. (set align() to None if the view is not to be considered for alignment). Eventually, the align() property should be turned into an AlignAtrribute class that is then dynamically attached to each view instance that wants to be aligned. The "None" enumeration element could then be removed since the *lack* of the AlignAttribute would be the same as "None".

Patch Set 1 #

Patch Set 2 : Reordered includes #

Patch Set 3 : std::conditional_t not available universally. Include ordering. #

Patch Set 4 : Explicitly include initializer_list header. More include ordering changes. #

Patch Set 5 : Constructor of SetCore() made public. #

Patch Set 6 : std::conditional_t not available universally. Include ordering. Explicitly include initializer_list… #

Patch Set 7 : Qualify access to inherited field #

Patch Set 8 : More clang-friendly changes #

Patch Set 9 : std::conditional_t not available universally. Include ordering. Explicitly include initializer_list… #

Patch Set 10 : std::conditional_t not available universally. Include ordering. Explicitly include initializer_list… #

Patch Set 11 : Sigh. Mac doesn't support std::map::emplace... #

Patch Set 12 : Locally define MulDiv() so it works everywhere #

Patch Set 13 : std::conditional_t not available universally. Include ordering. Explicitly include initializer_list… #

Patch Set 14 : Added more unittest cases for the [] operator in the set template Return anchors by reference for d… #

Patch Set 15 : Renamed AlignAttribute and associated types to FillAttribute #

Patch Set 16 : Renamed AlignAttribute and associated types to FillAttribute #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2344 lines, -0 lines) Patch
M base/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
A base/set_template.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +229 lines, -0 lines 0 comments Download
A base/set_template_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +161 lines, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 6 chunks +11 lines, -0 lines 0 comments Download
A ui/views/anchor_attribute.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +67 lines, -0 lines 0 comments Download
A ui/views/anchor_attribute.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +119 lines, -0 lines 0 comments Download
A ui/views/attributes.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +157 lines, -0 lines 0 comments Download
A ui/views/attributes.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +58 lines, -0 lines 0 comments Download
A ui/views/attributes_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +85 lines, -0 lines 0 comments Download
M ui/views/examples/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -0 lines 0 comments Download
A ui/views/examples/anchor_example.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +54 lines, -0 lines 0 comments Download
A ui/views/examples/anchor_example.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +188 lines, -0 lines 0 comments Download
M ui/views/examples/examples_window.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -0 lines 0 comments Download
A ui/views/examples/fill_example.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +47 lines, -0 lines 0 comments Download
A ui/views/examples/fill_example.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +83 lines, -0 lines 0 comments Download
A ui/views/fill_attribute.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +47 lines, -0 lines 0 comments Download
A ui/views/fill_attribute.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +26 lines, -0 lines 0 comments Download
A ui/views/layout/align_layout.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +50 lines, -0 lines 0 comments Download
A ui/views/layout/align_layout.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +197 lines, -0 lines 0 comments Download
A ui/views/layout/align_layout_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +403 lines, -0 lines 0 comments Download
A ui/views/layout/anchor_layout_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +341 lines, -0 lines 0 comments Download
M ui/views/view.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +9 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (27 generated)
kylix_rd
4 years, 4 months ago (2016-08-10 21:25:01 UTC) #4
This is the patch that contains the demo I showed on Monday (Aug. 8).

Powered by Google App Engine
This is Rietveld 408576698