Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: ppapi/c/private/ppb_nacl_private.h

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jvoung, dmichael reviews Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/api/private/ppb_nacl_private.idl ('k') | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/c/private/ppb_nacl_private.h
diff --git a/ppapi/c/private/ppb_nacl_private.h b/ppapi/c/private/ppb_nacl_private.h
index d89ed5b047de50a017f34a20f2567ed5edaeafcd..8be28293386a928db07279a716b00108a8b41e59 100644
--- a/ppapi/c/private/ppb_nacl_private.h
+++ b/ppapi/c/private/ppb_nacl_private.h
@@ -3,7 +3,7 @@
* found in the LICENSE file.
*/
-/* From private/ppb_nacl_private.idl modified Mon Jul 29 16:44:58 2013. */
+/* From private/ppb_nacl_private.idl modified Tue Aug 6 11:51:26 2013. */
#ifndef PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_
#define PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_
@@ -141,13 +141,15 @@ struct PPB_NaCl_Private_1_0 {
PP_FileHandle* nexe_handle,
struct PP_CompletionCallback callback);
/* Report to the browser that translation of the pexe for |instance|
- * has finished. The browser may then store the translation in the
- * cache. The renderer must first have called GetNexeFd for the same
- * instance. (It is not guaranteed to, however; if there is an error
- * or the file is too big for the cache, or the browser is in incognito
- * mode, no notification will be delivered to the plugin.)
+ * has finished, or aborted with an error. If |success| is true, the
+ * browser may then store the translation in the cache. The renderer
+ * must first have called GetNexeFd for the same instance. (The browser is
+ * not guaranteed to store the nexe even if |success| is true; if there is
+ * an error on the browser side, or the file is too big for the cache, or
+ * the browser is in incognito mode, no notification will be delivered to
+ * the plugin.)
*/
- void (*ReportTranslationFinished)(PP_Instance instance);
+ void (*ReportTranslationFinished)(PP_Instance instance, PP_Bool success);
/* Return true if we are off the record.
*/
PP_Bool (*IsOffTheRecord)(void);
« no previous file with comments | « ppapi/api/private/ppb_nacl_private.idl ('k') | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698