allow running "git cl format" from subdirectories

allow running "git cl format" from subdirectories

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=215724

[Dirk Pranke, 2013-08-05 22:39:37]

lgtm

[commit-bot: I haz the power, 2013-08-05 22:40:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mdempsky@google.com/22308002/1

[commit-bot: I haz the power, 2013-08-05 22:43:00]

Presubmit check for 22308002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/subprocess2_test.py failed
.....a
bb
ccc
a
bb
ccc
..a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
....a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
...F....................
======================================================================
FAIL: test_nag_timer (__main__.S2Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/subprocess2_test.py", line 618, in test_nag_timer
    self.assertEquals(w, expected)
AssertionError: Lists differ: ['No output for 3 seconds from... != ['No output
for 3 seconds from...

First list contains 2 additional elements.
First extra element 6:
No output for 12 seconds from command:

  ['No output for 3 seconds from command:',
   '/usr/bin/python tests/subprocess2_test.py --child --stdout --sleep_first',
   'No output for 6 seconds from command:',
   '/usr/bin/python tests/subprocess2_test.py --child --stdout --sleep_first',
   'No output for 9 seconds from command:',
-  '/usr/bin/python tests/subprocess2_test.py --child --stdout --sleep_first',
-  'No output for 12 seconds from command:',
   '/usr/bin/python tests/subprocess2_test.py --child --stdout --sleep_first']

----------------------------------------------------------------------
Ran 35 tests in 40.356s

FAILED (failures=1)


Presubmit checks took 156.8s to calculate.

[mdempsky_google, 2013-08-05 22:48:00]

On 2013/08/05 22:43:00, I haz the power (commit-bot) wrote:
> tests/subprocess2_test.py failed

This test passes when I run locally.  Please advise what to do.

[commit-bot: I haz the power, 2013-08-05 23:07:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mdempsky@google.com/22308002/1

[commit-bot: I haz the power, 2013-08-05 23:09:51]

Change committed as 215724

[Dirk Pranke, 2013-08-05 23:11:13]

I think this was just a flaky failure :(.


On Mon, Aug 5, 2013 at 3:48 PM, <mdempsky@google.com> wrote:

> On 2013/08/05 22:43:00, I haz the power (commit-bot) wrote:
>
>> tests/subprocess2_test.py failed
>>
>
> This test passes when I run locally.  Please advise what to do.
>
>
https://codereview.chromium.**org/22308002/<https://codereview.chromium.org/2...
>

[Isaac (away), 2013-08-06 18:32:24]

I took a look at the test -- it's not surprising it's flaky:

file A:
out = capture(<file B>, nag_timer=3s)
verify that nags at 3s, 6s and 9s are printed.

file B:
sleep 10