chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h - Issue 2230773002: Migrate add to homescreen data fetcher to use InstallableManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

Issue 2230773002: Migrate add to homescreen data fetcher to use InstallableManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More tidying Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

index 3b1de6ade2288029e0cb01e08a829f2dcc39325b..296011b65785f4a9bf31a87b6829b72e01154a70 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

@@ -6,21 +6,21 @@

#define CHROME_BROWSER_ANDROID_WEBAPPS_ADD_TO_HOMESCREEN_DIALOG_HELPER_H_

#include "base/android/jni_android.h"

-#include "base/android/jni_weak_ref.h"

+#include "base/android/scoped_java_ref.h"

#include "base/macros.h"

-#include "chrome/browser/android/shortcut_info.h"

#include "chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h"

-#include "content/public/common/manifest.h"

+#include "third_party/skia/include/core/SkBitmap.h"

namespace content {

class WebContents;

-} // namespace content

namespace IPC {

class Message;

}

class GURL;

+struct ShortcutInfo;

// AddToHomescreenDialogHelper is the C++ counterpart of

// org.chromium.chrome.browser's AddToHomescreenDialogHelper in Java. The object