Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 22306002: GCP2.0 Device: New timeouts (5 sec). (Closed)

Created:
7 years, 4 months ago by maksymb
Modified:
7 years, 4 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

GCP2.0 Device: New timeouts (5 sec). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215847

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : Changed error when getClaimToken is not ready #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M cloud_print/gcp20/prototype/printer.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/privet_http_server.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gene
https://codereview.chromium.org/22306002/diff/1/cloud_print/gcp20/prototype/privet_http_server.cc File cloud_print/gcp20/prototype/privet_http_server.cc (right): https://codereview.chromium.org/22306002/diff/1/cloud_print/gcp20/prototype/privet_http_server.cc#newcode301 cloud_print/gcp20/prototype/privet_http_server.cc:301: *current_response = CreateErrorWithTimeout("device_busy", device_busy should be still 30 sec. ...
7 years, 4 months ago (2013-08-05 22:22:08 UTC) #1
maksymb
https://codereview.chromium.org/22306002/diff/1/cloud_print/gcp20/prototype/privet_http_server.cc File cloud_print/gcp20/prototype/privet_http_server.cc (right): https://codereview.chromium.org/22306002/diff/1/cloud_print/gcp20/prototype/privet_http_server.cc#newcode301 cloud_print/gcp20/prototype/privet_http_server.cc:301: *current_response = CreateErrorWithTimeout("device_busy", On 2013/08/05 22:22:08, gene wrote: > ...
7 years, 4 months ago (2013-08-05 22:30:59 UTC) #2
maksymb
https://codereview.chromium.org/22306002/diff/1/cloud_print/gcp20/prototype/privet_http_server.cc File cloud_print/gcp20/prototype/privet_http_server.cc (right): https://codereview.chromium.org/22306002/diff/1/cloud_print/gcp20/prototype/privet_http_server.cc#newcode301 cloud_print/gcp20/prototype/privet_http_server.cc:301: *current_response = CreateErrorWithTimeout("device_busy", On 2013/08/05 22:22:08, gene wrote: > ...
7 years, 4 months ago (2013-08-06 01:18:54 UTC) #3
maksymb
Also, changed error when Claim Token is not ready yet.
7 years, 4 months ago (2013-08-06 01:22:40 UTC) #4
gene
lgtm
7 years, 4 months ago (2013-08-06 01:23:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maksymb@chromium.org/22306002/9001
7 years, 4 months ago (2013-08-06 01:43:42 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 07:56:27 UTC) #7
Message was sent while issue was closed.
Change committed as 215847

Powered by Google App Engine
This is Rietveld 408576698