Issue 22305002: NULL check before calling thumbnail_db_ method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22305002: NULL check before calling thumbnail_db_ method. (Closed)

Created:
7 years, 4 months ago by Scott Hess - ex-Googler

Modified:
7 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

NULL check before calling thumbnail_db_ method. If thumbnail_db_ Init() fails, then reset() is called, so later calls need to be checked. BUG=242636 TEST=Chrome stops crashing in the field. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215837

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/history/history_backend.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/22305002/1

7 years, 4 months ago (2013-08-06 04:02:38 UTC) #3

Message was sent while issue was closed.

Change committed as 215837