Issue 22303004: Update pairing information so that reconnect doesn't request a PIN.

Issue 22303004: Update pairing information so that reconnect doesn't request a PIN. (Closed)

Created:
7 years, 4 months ago by Jamie

Modified:
7 years, 4 months ago

Reviewers:
alexeypa (please no reviews)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update pairing information so that reconnect doesn't request a PIN. BUG=270976 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216816

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reviewer comments. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	remoting/webapp/client_screen.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	remoting/webapp/session_connector.js	View	1	3 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

lgtm https://codereview.chromium.org/22303004/diff/1/remoting/webapp/session_connector.js File remoting/webapp/session_connector.js (right): https://codereview.chromium.org/22303004/diff/1/remoting/webapp/session_connector.js#newcode204 remoting/webapp/session_connector.js:204: this.clientPairingId_ = clientId; nit: update connectMe2MeInternal_ to call ...

7 years, 4 months ago (2013-08-09 21:35:26 UTC) #2

Jamie

fyi https://codereview.chromium.org/22303004/diff/1/remoting/webapp/session_connector.js File remoting/webapp/session_connector.js (right): https://codereview.chromium.org/22303004/diff/1/remoting/webapp/session_connector.js#newcode204 remoting/webapp/session_connector.js:204: this.clientPairingId_ = clientId; On 2013/08/09 21:35:26, alexeypa wrote: ...

7 years, 4 months ago (2013-08-09 21:46:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/22303004/1003

7 years, 4 months ago (2013-08-09 21:53:36 UTC) #4

Message was sent while issue was closed.

Change committed as 216816

Expand Messages | Collapse Messages